Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter and nicer output for tp test #51

Merged
merged 4 commits into from Mar 23, 2018
Merged

Shorter and nicer output for tp test #51

merged 4 commits into from Mar 23, 2018

Conversation

alvagante
Copy link
Member

Before submitting your PR

  1. Open an issue and refer to its number in your PR title
  2. If it's a bug and you have the solution, go on with the PR!
  3. If it's an enhancement, please wait for our feedback before starting to work on it
  4. Please run puppet-lint on your code and ensure it's compliant

After submitting your PR

  1. Verify Travis checks and eventually fix the errors
  2. Feel free to ping us if we don't reply promptly

@alvagante
Copy link
Member Author

alvagante commented Mar 22, 2018

3 Warnings
⚠️ There’re changes in manifests, but not tests. That’s OK as long as you’re refactoring existing code.
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.
⚠️ Big PR! Big changes, big things may happen! Check them.
1 Message
📖 There are changes on Hiera data files. They will probably affect one or more params.

Here's an example of a CHANGELOG.md entry:

* [#51](https://github.com/example42/puppet-tp/pull/51): Shorter and nicer output  for tp test - [@alvagante](https://github.com/alvagante).

Generated by 🚫 Danger

@coveralls
Copy link

coveralls commented Mar 22, 2018

Coverage Status

Coverage remained the same at 96.701% when pulling 0b465ba on short_tptest into c6a263a on master.

@alvagante alvagante merged commit b8bf3aa into master Mar 23, 2018
@alvagante alvagante deleted the short_tptest branch March 2, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants