Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API of ExaPF before release 0.5.0 #146

Merged
merged 2 commits into from
Apr 4, 2021
Merged

Update API of ExaPF before release 0.5.0 #146

merged 2 commits into from
Apr 4, 2021

Conversation

frapac
Copy link
Member

@frapac frapac commented Apr 2, 2021

This PR:

  • updates the constructors of PolarForm and ReducedSpaceEvaluator
  • adds a new convenient powerflow function
  • updates the scripts in scripts/ to the new API
  • adds a proper script to benchmark evaluators
  • fix clashes in naming

See #143

* add a new signature for powerflow, allowing for quicksolve
* change constructor of ReducedSpaceEvaluator
* add a new constructor for PolarForm
* polar: rename jtprod! as jacobian_transpose_product!
* polar: rename objective as cost_production
* fix clashes in naming
@frapac frapac mentioned this pull request Apr 2, 2021
8 tasks
print("HLagPen-prod \t")
@time ExaPF.hessian_lagrangian_penalty_prod!(nlp, hv, u, y, 1.0, v, w)
@btime ExaPF.hessian_lagrangian_penalty_prod!($nlp, $hv, $u, $y, 1.0, $v, $w)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Read up on @btime now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This macro is quite convenient!

@info("SlackAugLagEvaluator")
run_slackaug(nlp, u, device=CPU())
ExaPF.reset!(nlp)
# @info("SlackEvaluator")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? Is this commented out on purpose?

@michel2323 michel2323 merged commit b0c2d2a into develop Apr 4, 2021
@frapac frapac deleted the fp/renaming branch April 21, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants