Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request url broken with @ActivationRequestParameters #18

Closed
ccburnley opened this issue Jun 9, 2012 · 3 comments
Closed

Request url broken with @ActivationRequestParameters #18

ccburnley opened this issue Jun 9, 2012 · 3 comments

Comments

@ccburnley
Copy link

The urls generated by the javascript don't account for their being parameters already part of the URL.

For example:

exanpe-t5-lib.js : 2430

        this.url + "?" + Exanpe.PasswordStrengthChecker.PARAM_NAME + "=" + password,

the URL if the page has activation request parameters already has a "?" in it and would in this case need to be a "&".

@lguerin
Copy link
Member

lguerin commented Jun 10, 2012

I have pushed a fix. Thank for the issue report.

@ccburnley
Copy link
Author

Works great for me, thanks.

BTW, where can I get snapshots of 1.3.0 ?

@lguerin
Copy link
Member

lguerin commented Jun 11, 2012

I have just created a bug fix release : exanpe-t5-lib-1.2.1.
This version should be available into Maven central in few hours.

timcu added a commit to timcu/exanpe-t5-lib that referenced this issue Jun 16, 2014
* master:
  exanpe#18 Request url broken with @ActivationRequestParameters
  Fix label display
  Formatting
  Force backward compatibility with Java 1.5
  Allow user to use complex tml to define the marker info on a gmap
  Updating BinaryImg with ByteArrayIS buffering and InputStream proper
closing Add an error image
  Adding commons-io as a dependency A pretty standard dependency
  Adding Resizable mixin Adding @ since Restoring enforcer
  Adding test page with byte array + persist !
  Adding BinaryImg component
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare for next development iteration

Conflicts:
	pom.xml
	src/main/resources/fr/exanpe/t5/lib/components/js/exanpe-t5-lib.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants