Adds Delta format import integration #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the list of files for the latest snapshot is obtained in metadata udf. This done using locally running Spark session and DeltaLog. However, for accessing the remote storage blobs, e.g, S3, Azure Blob, an additional configuration settings will be required.
AnastasiiaSergienko
suggested changes
Mar 12, 2020
Comment on lines
103
to
104
| val key = entry.getKey() | ||
| val value = entry.getValue() |
There was a problem hiding this comment.
What do the key and value represent? It's not clear from names
There was a problem hiding this comment.
It is a HadoopConfiguration, that stores configuration parameters as Map.Entry[String, String].
Going to rename them to hadoopConfigKey/Value.
| assert(set === Set(1, 2, 3, 4, 5)) | ||
| } | ||
|
|
||
| test("stream returns records from the overwite delta snapshot") { |
There was a problem hiding this comment.
overwite -> overwrite?
src/test/scala/com/exasol/cloudetl/bucket/DeltaFormatBucketTest.scala
Outdated
Show resolved
Hide resolved
Co-Authored-By: Anastasiia Sergienko <46891819+AnastasiiaSergienko@users.noreply.github.com>
AnastasiiaSergienko
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31.