-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dbapi2 compatibility driver #145
Conversation
Not sure if it is a good idea. Historically pyexasol was slightly incompatible with DB API 2.0 on purpose. It forced users to look at documentation for a few minutes instead of mindlessly copying incorrect advice from StackOverflow. Main issues with DB API 2.0:
Fundamentally implementing it would cause more harm than good. |
Hi @littleK0i, I understand and share your concern. That is why I made the shim a separate package. It won't even be part of the Why we are doing this?We have seen use cases and received requests in the past where DBAPI2 compliance was desired and reasonable, or the only way to integrate with other frameworks. Therefore, we believe we should allow users to achieve this. Although there is In the end, it is up to the user and their needs. I do not see why we should patronize the library users. We should make the right things easy and the potentially harmful ones harder, but ultimately the user should be able to decide because they should know what they need.
Having worked intensively with C++ in the past (8+ years) 😬, I totally understand where you're coming from. Nevertheless, any suggestions and discussions are welcome so that we can enable the user to make a well-informed decision about the potential tradeoffs at hand. I hope this helps to better understand the background of this change. best 🗒️ Side note: |
Co-authored-by: Christoph Kuhnke <github@kuhnke.net>
Co-authored-by: Christoph Kuhnke <github@kuhnke.net>
Co-authored-by: Christoph Kuhnke <github@kuhnke.net>
Co-authored-by: Christoph Kuhnke <github@kuhnke.net>
I'll merge this PR for now. If you have any further feedback or feel that I may have been too quick with this change, please feel free to contact me directly via email. Your feedback is always highly appreciated and welcome. Best, |
Migrate dbapi2 compliant shim/driver from SQLA.