Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale specific formatting of decimal point #119

Closed
kaklakariada opened this issue Aug 31, 2022 · 1 comment
Closed

Locale specific formatting of decimal point #119

kaklakariada opened this issue Aug 31, 2022 · 1 comment
Assignees
@ckunki
Labels
bug Unwanted / harmful behavior

Comments

@kaklakariada
Copy link
Contributor

Method SqlGenerationVisitor.visit(SqlLiteralDouble) returns values with decimal point , when the locale is set to e.g. en_DE.

This is unexpected, the visit method should always return decimal point . independent of the locale.

Other methods may also be affected.
@kaklakariada kaklakariada added the bug Unwanted / harmful behavior label Aug 31, 2022
@kaklakariada kaklakariada mentioned this issue Aug 31, 2022
Closed
@ckunki
Copy link
Collaborator

ckunki commented Sep 7, 2022

see exasol/hive-virtual-schema#28

This was referenced Sep 7, 2022
Closed
Merged
@ckunki ckunki self-assigned this Sep 13, 2022
ckunki added a commit that referenced this issue Sep 13, 2022
@ckunki
#119 fixed, also fixed tests
75b3ee7
ckunki added a commit that referenced this issue Sep 13, 2022
@ckunki
Added #119 to changes file
1482013
ckunki added a commit that referenced this issue Sep 13, 2022
@ckunki @redcatbear
#120: Supported using the push down request to specify the datatypes… (
b61e346 
#121)

* #120: Supported using the push down request to specify the datatypes of result set.
* updated virtual-schema-common-java  to version 16.1.0
* #119 fixed

Co-authored-by: Sebastian Bär <sebastian.baer@exasol.com>
@ckunki ckunki closed this as completed Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckunki ckunki

Labels
bug Unwanted / harmful behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaklakariada @ckunki