Skip to content

Commit

Permalink
#151 replaced long casts in integration test with literals
Browse files Browse the repository at this point in the history
  • Loading branch information
snehlsen committed May 7, 2019
1 parent 251d57c commit b3bc276
Showing 1 changed file with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ void testInnerJoin() throws SQLException {
final String query = "SELECT * FROM " + VIRTUAL_SCHEMA + ".t1 a INNER JOIN " + VIRTUAL_SCHEMA
+ ".t2 b ON a.x=b.x";
final ResultSet result = executeQuery(query);
assertAll(() -> matchNextRow(result, (long) 2, "bbb", (long) 2, "bbb"), () -> assertFalse(result.next()));
assertAll(() -> matchNextRow(result, 2L, "bbb", 2L, "bbb"), () -> assertFalse(result.next()));
}

@Test
Expand All @@ -252,8 +252,8 @@ void testLeftJoin() throws SQLException {
final String query = "SELECT * FROM " + VIRTUAL_SCHEMA + ".t1 a LEFT OUTER JOIN " + VIRTUAL_SCHEMA
+ ".t2 b ON a.x=b.x ORDER BY a.x";
final ResultSet result = executeQuery(query);
matchNextRow(result, (long) 1, "aaa", null, null);
matchNextRow(result, (long) 2, "bbb", (long) 2, "bbb");
matchNextRow(result, 1L, "aaa", null, null);
matchNextRow(result, 2L, "bbb", 2L, "bbb");
assertFalse(result.next());
}

Expand All @@ -262,37 +262,37 @@ void testRightJoin() throws SQLException {
final String query = "SELECT * FROM " + VIRTUAL_SCHEMA + ".t1 a RIGHT OUTER JOIN " + VIRTUAL_SCHEMA
+ ".t2 b ON a.x=b.x ORDER BY a.x";
final ResultSet result = executeQuery(query);
assertAll(() -> matchNextRow(result, (long) 2, "bbb", (long) 2, "bbb"),
() -> matchNextRow(result, null, null, (long) 3, "ccc"), () -> assertFalse(result.next()));
assertAll(() -> matchNextRow(result, 2L, "bbb", 2L, "bbb"),
() -> matchNextRow(result, null, null, 3L, "ccc"), () -> assertFalse(result.next()));
}

@Test
void testFullOuterJoin() throws SQLException {
final String query = "SELECT * FROM " + VIRTUAL_SCHEMA + ".t1 a FULL OUTER JOIN " + VIRTUAL_SCHEMA
+ ".t2 b ON a.x=b.x ORDER BY a.x";
final ResultSet result = executeQuery(query);
assertAll(() -> matchNextRow(result, (long) 1, "aaa", null, null),
() -> matchNextRow(result, (long) 2, "bbb", (long) 2, "bbb"),
() -> matchNextRow(result, null, null, (long) 3, "ccc"), () -> assertFalse(result.next()));
assertAll(() -> matchNextRow(result, 1L, "aaa", null, null),
() -> matchNextRow(result, 2L, "bbb", 2L, "bbb"),
() -> matchNextRow(result, null, null, 3L, "ccc"), () -> assertFalse(result.next()));
}

@Test
void testRightJoinWithComplexCondition() throws SQLException {
final String query = "SELECT * FROM " + VIRTUAL_SCHEMA + ".t1 a RIGHT OUTER JOIN " + VIRTUAL_SCHEMA
+ ".t2 b ON a.x||a.y=b.x||b.y ORDER BY a.x";
final ResultSet result = executeQuery(query);
assertAll(() -> matchNextRow(result, (long) 2, "bbb", (long) 2, "bbb"),
() -> matchNextRow(result, null, null, (long) 3, "ccc"), () -> assertFalse(result.next()));
assertAll(() -> matchNextRow(result, 2L, "bbb", 2L, "bbb"),
() -> matchNextRow(result, null, null, 3L, "ccc"), () -> assertFalse(result.next()));
}

@Test
void testFullOuterJoinWithComplexCondition() throws SQLException {
final String query = "SELECT * FROM " + VIRTUAL_SCHEMA + ".t1 a FULL OUTER JOIN " + VIRTUAL_SCHEMA
+ ".t2 b ON a.x-b.x=0 ORDER BY a.x";
final ResultSet result = executeQuery(query);
assertAll(() -> matchNextRow(result, (long) 1, "aaa", null, null),
() -> matchNextRow(result, (long) 2, "bbb", (long) 2, "bbb"),
() -> matchNextRow(result, null, null, (long) 3, "ccc"), () -> assertFalse(result.next()));
assertAll(() -> matchNextRow(result, 1L, "aaa", null, null),
() -> matchNextRow(result, 2L, "bbb", 2L, "bbb"),
() -> matchNextRow(result, null, null, 3L, "ccc"), () -> assertFalse(result.next()));
}

// Identifier Test - CONVERT_TO_UPPER mode --------------------------------
Expand Down

0 comments on commit b3bc276

Please sign in to comment.