Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement validation of the adapter properties in the dialects. #155

Closed
AnastasiiaSergienko opened this issue Apr 16, 2019 · 1 comment
Closed

Implement validation of the adapter properties in the dialects. #155

AnastasiiaSergienko opened this issue Apr 16, 2019 · 1 comment
Assignees
@AnastasiiaSergienko
Labels
refactoring Code improvement without behavior change

Comments

@AnastasiiaSergienko
Copy link
Contributor

  1. Move common validation from JdbcAdapterProperties class to the AbstractSqlDialect.
  2. Move dialect-specific checks to the appropriate dialects.
  3. Add missed checks
@AnastasiiaSergienko AnastasiiaSergienko added the refactoring Code improvement without behavior change label Apr 16, 2019
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Apr 16, 2019
AnastasiiaSergienko added a commit that referenced this issue Apr 17, 2019
@AnastasiiaSergienko
#155: moved validation logic to dialects
3875b4d
AnastasiiaSergienko added a commit that referenced this issue Apr 18, 2019
@AnastasiiaSergienko
#155: used AdapterProperties class instead of Map
487d9cd
AnastasiiaSergienko added a commit that referenced this issue Apr 24, 2019
@AnastasiiaSergienko
#155: finished validation logic
7381489
AnastasiiaSergienko added a commit that referenced this issue Apr 24, 2019
@AnastasiiaSergienko
#155: clean up code
bed93a4
AnastasiiaSergienko added a commit that referenced this issue Apr 26, 2019
@AnastasiiaSergienko
#155: fixed review findings
2f89685
AnastasiiaSergienko added a commit that referenced this issue Apr 26, 2019
@AnastasiiaSergienko
#155: fixed review findings
8e382d1
AnastasiiaSergienko added a commit that referenced this issue Apr 26, 2019
@AnastasiiaSergienko
enhancement/155_moved_validation_logic_to_dialects (#158)
68edbea 
* #155: moved validation logic to dialects
* Fixed integration tests errors
redcatbear added a commit that referenced this issue May 2, 2019
@redcatbear
Enhancement/131 refactor metadata reading (#153)
adbc826 
* #45: Rewrote parts of the JDBC adapter to use the new commons code.
* #121: Refactored request dispatching
* #124: Read Redshift metadata
* #131: Refactored general metadata reading
* #155: Moved validation logic to dialects
* #163: Fixed Hive integration tests
redcatbear added a commit that referenced this issue May 3, 2019
@redcatbear
Enhancement/162 automatically register sql dialect adapters (#165)
d947f2c 
* #45: Rewrote parts of the JDBC adapter to use the new `common` code.
* #121: Used new request dispatching from `common`
* #123: Improved how schemas identify support for structural elements
* #131: Refactored metadata reading
* #155: moved property validation logic to dialects
* #162: Automatically register SQL dialects.
@AnastasiiaSergienko
Copy link
Contributor Author

Closed with #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnastasiiaSergienko AnastasiiaSergienko

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AnastasiiaSergienko