#369 Type mapping documentation + refactoring #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anastasiia Sergienko <46891819+AnastasiiaSergienko@users.noreply.github.com>
Co-authored-by: Anastasiia Sergienko <46891819+AnastasiiaSergienko@users.noreply.github.com>
AnastasiiaSergienko
suggested changes
Aug 7, 2020
doc/dialects/oracle.md
Outdated
| | -------------------------------------------------------------------------------- | --------- | -------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | VARCHAR2(size) | ✓ | VARCHAR | | | ||
| | NVARCHAR2(size) | ✓ | VARCHAR | | | ||
| | NUMBER \[ (p \[, s\]) \] | ✓ | NUMBER or VARCHAR(2000000) | NUMBER with precision > 36 are casted to VARCHAR to prevent a loss of precision. [*](#Mapping-of-number-types) | |
There was a problem hiding this comment.
Does the star lead somewhere? I can't click it.
src/main/java/com/exasol/adapter/dialects/oracle/OracleColumnMetadataReader.java
Outdated
Show resolved
Hide resolved
| case INTERVAL_DAY_TO_SECOND: | ||
| case ORACLE_BINARY_FLOAT: | ||
| case ORACLE_BINARY_DOUBLE: | ||
| case Types.ROWID: |
There was a problem hiding this comment.
According to the data mapping table, this data type is not supported. Check it in the test. If there is no test, create one. If it's not supported, remove it from here too
src/test/java/com/exasol/adapter/dialects/oracle/OracleSqlDialectIT.java
Outdated
Show resolved
Hide resolved
AnastasiiaSergienko
suggested changes
Aug 13, 2020
| @@ -18,7 +19,7 @@ | |||
| private boolean requiresSelectListAliasesForLimit = false; | |||
| private static final String TIMESTAMP_FORMAT = "'YYYY-MM-DD HH24:MI:SS.FF3'"; | |||
| private static final List<String> TYPE_NAMES_REQUIRING_CAST = List.of("TIMESTAMP", "INTERVAL", "BINARY_FLOAT", | |||
| "BINARY_DOUBLE", "ROWID", "UROWID", "BLOB"); | |||
| "BINARY_DOUBLE", "BLOB"); | |||
There was a problem hiding this comment.
Remove also blob from here, we don't support it
| @@ -273,8 +274,6 @@ private String getProjectionString(final SqlColumn column, final String projecti | |||
| + ")"; | |||
| } else if (typeName.equals("NUMBER")) { | |||
| return getNumberProjectionString(column, projectionString, (OracleSqlDialect) dialect); | |||
| } else if (typeName.equals("ROWID") || typeName.equals("UROWID")) { | |||
| return "ROWIDTOCHAR(" + projectionString + ")"; | |||
| } else if (typeName.equals("BLOB")) { | |||
There was a problem hiding this comment.
And from here too
|
Kudos, SonarCloud Quality Gate passed!
|
jakobbraun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#369 Type mapping documentation
#370 Cleanup of oracle dialect