Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#263: reviewed sybase dialect and removed an unused MetadataReader #373

Merged

Conversation

AnastasiiaSergienko
Copy link
Contributor

Closes #263

@AnastasiiaSergienko AnastasiiaSergienko added bug Unwanted / harmful behavior refactoring Code improvement without behavior change labels Aug 20, 2020
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Aug 20, 2020
jakobbraun
jakobbraun previously approved these changes Aug 20, 2020
Copy link
Contributor

@jakobbraun jakobbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with minor comment

doc/changes/changes_4.0.4.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AnastasiiaSergienko AnastasiiaSergienko merged commit 682b14d into master Aug 21, 2020
@AnastasiiaSergienko AnastasiiaSergienko deleted the bugs/263_sybase_dialect_metadata_reader_ignored branch August 21, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unwanted / harmful behavior refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SybaseMetadataReader is not used in the Sybase dialect
2 participants