Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* #396: Updated to the virtual-schema-common-java:6.0.0 #397

Merged

Conversation

AnastasiiaSergienko
Copy link
Contributor

@AnastasiiaSergienko AnastasiiaSergienko commented Sep 30, 2020

Closes #396

@AnastasiiaSergienko AnastasiiaSergienko added the refactoring Code improvement without behavior change label Sep 30, 2020
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Sep 30, 2020
morazow
morazow previously approved these changes Sep 30, 2020
Copy link
Contributor

@morazow morazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor editorial changes in changes file.

* #386: Remove the documentation that was moved to the portal, added links instead.
* #394: Described 'No suitable driver found', added a note that Hive 1.1.0 has problems with its driver.
* #394: Described * suitable driver found', added a note that Hive 1.1.0 has problems with its driver.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asterisk (*) are mixed up somehow.


## Refactoring

* #263: Removed SybaseMetadataReader class as it was not used by the dialect.
* #381: Migrated from version.sh to artifact-reference-checker-maven-plugin.
* #389: Improved connection error handling.
* #389:*proved connection error handling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@AnastasiiaSergienko AnastasiiaSergienko merged commit 54e88dd into master Sep 30, 2020
@AnastasiiaSergienko AnastasiiaSergienko deleted the refactoring/396_update_to_common_jdbc_6.0.0 branch September 30, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to virtual-schema-common-jdbc 6.0.0
2 participants