Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* #401: Updated to the virtual-schema-common-jdbc:6.1.0 #403

Merged
merged 12 commits into from
Nov 17, 2020
Merged

* #401: Updated to the virtual-schema-common-jdbc:6.1.0 #403

merged 12 commits into from
Nov 17, 2020

Conversation

AnastasiiaSergienko
Copy link
Contributor

@AnastasiiaSergienko AnastasiiaSergienko commented Nov 4, 2020 •
edited

Closes #401

@AnastasiiaSergienko AnastasiiaSergienko added the refactoring Code improvement without behavior change label Nov 4, 2020
@AnastasiiaSergienko AnastasiiaSergienko self-assigned this Nov 4, 2020
redcatbear
redcatbear requested changes Nov 5, 2020
View reviewed changes
doc/dialects/athena.md Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/athena/AthenaIdentifier.java Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/generic/GenericSqlDialect.java Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/hive/HiveSqlDialect.java Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/oracle/OracleSqlDialect.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/sqlserver/SqlServerIdentifier.java Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/sybase/SybaseSqlDialect.java Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/teradata/TeradataSqlDialect.java Outdated Show resolved Hide resolved
src/test/java/com/exasol/adapter/dialects/mysql/MySqlSqlDialectTest.java Outdated Show resolved Hide resolved
src/test/java/com/exasol/adapter/dialects/impala/ImpalaSqlDialectTest.java Outdated Show resolved Hide resolved
exanm
exanm suggested changes Nov 6, 2020
View reviewed changes
doc/dialects/athena.md Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/mysql/MySqlSqlDialect.java Outdated Show resolved Hide resolved
src/test/java/com/exasol/adapter/dialects/mysql/MySqlSqlDialectTest.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/teradata/TeradataSqlDialect.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/oracle/OracleSqlDialect.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/bigquery/BigQueryIdentifier.java Outdated Show resolved Hide resolved
src/test/java/com/exasol/adapter/dialects/bigquery/BigQuerySqlDialectTest.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/athena/AthenaIdentifier.java Show resolved Hide resolved
src/test/java/com/exasol/adapter/dialects/athena/AthenaIdentifierTest.java Show resolved Hide resolved
src/test/java/com/exasol/adapter/dialects/athena/AthenaSqlDialectTest.java Outdated Show resolved Hide resolved
redcatbear
redcatbear previously approved these changes Nov 9, 2020
View reviewed changes
@exanm exanm self-requested a review November 9, 2020 16:19
exanm
exanm suggested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@exanm exanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review all of the getStringLiteral implementations because of missing documentation links.

src/main/java/com/exasol/adapter/dialects/impala/ImpalaIdentifier.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/mysql/MySqlSqlDialect.java Outdated Show resolved Hide resolved
src/test/java/com/exasol/adapter/dialects/mysql/MySqlSqlDialectTest.java Outdated Show resolved Hide resolved
@AnastasiiaSergienko @exanm
Apply suggestions from code review
9216095 
Co-authored-by: exanm <48916233+exanm@users.noreply.github.com>
exanm
exanm suggested changes Nov 10, 2020
View reviewed changes
src/main/java/com/exasol/adapter/dialects/athena/AthenaSqlDialect.java Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/db2/DB2SqlDialect.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/hive/HiveSqlDialect.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/postgresql/PostgreSQLSqlDialect.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/postgresql/PostgreSQLSqlDialect.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/postgresql/PostgreSQLSqlDialect.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/redshift/RedshiftSqlDialect.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/saphana/SapHanaSqlDialect.java Outdated Show resolved Hide resolved
src/main/java/com/exasol/adapter/dialects/sybase/SybaseSqlDialect.java Outdated Show resolved Hide resolved
@AnastasiiaSergienko @exanm
Apply suggestions from code review
c3bc08a 
Co-authored-by: exanm <48916233+exanm@users.noreply.github.com>
exanm
exanm previously approved these changes Nov 13, 2020
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

85.9% 85.9% Coverage
0.4% 0.4% Duplication

@AnastasiiaSergienko AnastasiiaSergienko merged commit 731a777 into master Nov 17, 2020
@AnastasiiaSergienko AnastasiiaSergienko deleted the enhancement/401_update_to_the_latest_common_jdbc branch November 17, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redcatbear redcatbear redcatbear left review comments

@exanm exanm exanm left review comments

Assignees

@AnastasiiaSergienko AnastasiiaSergienko

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to the latest common-jdbc
3 participants
@AnastasiiaSergienko @redcatbear @exanm