Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Generic dialect #452

Merged
merged 8 commits into from
Jan 18, 2021
Merged

Remove Generic dialect #452

merged 8 commits into from
Jan 18, 2021

Conversation

chiaradiamarcelo
Copy link
Contributor

Closes #451.

@chiaradiamarcelo chiaradiamarcelo self-assigned this Jan 18, 2021
@chiaradiamarcelo chiaradiamarcelo added the refactoring Code improvement without behavior change label Jan 18, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jan 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

AnastasiiaSergienko
AnastasiiaSergienko suggested changes Jan 18, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@chiaradiamarcelo chiaradiamarcelo merged commit cbc769d into master Jan 18, 2021
@chiaradiamarcelo chiaradiamarcelo deleted the refactoring/451_remove_generic_vs branch January 18, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnastasiiaSergienko AnastasiiaSergienko AnastasiiaSergienko approved these changes

Assignees

@chiaradiamarcelo chiaradiamarcelo

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Generic implementation as it's been migrated to is own repository
2 participants
@chiaradiamarcelo @AnastasiiaSergienko