Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add friendly error if canvasElementId missing #2885

Merged
merged 1 commit into from
Jan 14, 2024
Merged

fix: Add friendly error if canvasElementId missing #2885

merged 1 commit into from
Jan 14, 2024

Conversation

jyoung4242
Copy link
Contributor

…throw error if not

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #

Changes:

  • change 1
  • change 2

@eonarheim eonarheim changed the title added test for dom element existence prior to assigning this.canvas, … fix: Add friendly error if canvasElementId missing Jan 14, 2024
@eonarheim eonarheim merged commit 9c46824 into excaliburjs:main Jan 14, 2024
5 checks passed
eonarheim pushed a commit that referenced this pull request Jan 26, 2024
@jyoung4242 @eonarheim
fix: Add friendly error if canvasElementId missing(#2885)
ea86b3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eonarheim eonarheim eonarheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jyoung4242 @eonarheim