Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chess set #158

Merged
merged 6 commits into from
Jun 26, 2021
Merged

Chess set #158

merged 6 commits into from
Jun 26, 2021

Conversation

PRTBRM
Copy link
Contributor

@PRTBRM PRTBRM commented Jun 24, 2021

No description provided.

@vercel
Copy link

vercel bot commented Jun 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw-libraries/DCbGNL1zXDEyz9rubidx5tQHKgh9
✅ Preview: https://excalidraw-libraries-git-fork-prtbrm-main-excalidraw.vercel.app

@PRTBRM
Copy link
Contributor Author

PRTBRM commented Jun 24, 2021

Hey so I'm not sure what Vercel is, and this is my first pull request. Did I not do something correctly?

libraries.json Outdated Show resolved Hide resolved
@ad1992
Copy link
Member

ad1992 commented Jun 25, 2021

Hey so I'm not sure what Vercel is, and this is my first pull request. Did I not do something correctly?

It's fixed now, there was a syntax error in libraries.json due to which the deployment was failing

@dwelle
Copy link
Member

dwelle commented Jun 25, 2021

Got bored so I created alternative chess pieces. Take it or leave it.

https://excalidraw.com/#json=6214175047024640,yvM0RBAH1AxWJDtibzOl_g

image

@PRTBRM
Copy link
Contributor Author

PRTBRM commented Jun 25, 2021

Got bored so I created alternative chess pieces. Take it or leave it.

https://excalidraw.com/#json=6214175047024640,yvM0RBAH1AxWJDtibzOl_g

image

Yes @dwelle!! That's what I was trying to create but couldn't figure out how to use my Apple Pencil very effectively. So I went with just using shapes. Ok cool - so what are the next steps to use your pieces instead? I am super new to git, but I want to see this in Excalidraw!! thank you

@dwelle
Copy link
Member

dwelle commented Jun 25, 2021

So I went with just using shapes. Ok cool - so what are the next steps to use your pieces instead? I am super new to git, but I want to see this in Excalidraw!! thank you

No prob, I can add them to the library later, and fix the conflict as well.

@dwelle
Copy link
Member

dwelle commented Jun 26, 2021

@PRTBRM I've also updated the chess board itself. Check it out. If everything's looking good, we can merge.

image

Copy link
Member

@ad1992 ad1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo this looks amazing 🔥

@PRTBRM
Copy link
Contributor Author

PRTBRM commented Jun 26, 2021

Fantastic!! So is there anything I need to do for this to get merged and then be available in the library?

@dwelle dwelle merged commit 5570ac1 into excalidraw:main Jun 26, 2021
@dwelle
Copy link
Member

dwelle commented Jun 26, 2021

Merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants