-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add line chart and paste dialog selection #2670
Conversation
…o new-line-chart * 'new-line-chart' of github.com:excalidraw/excalidraw: Update constants.ts
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/excalidraw/excalidraw/hq7x54jih |
While it adds friction, I reckon you also won't be pasting charts all the time, so it's kinda ok? That said, I noticed |
By fast pasting!! 🤣 (Just kidding.. I updated the description) |
Reading the updated description, I'd start with what you suggest: simply highlight what was selected previously. Later we can iterate on the |
I think this is good. Let's implement it and ship it! 🚀 |
I've moved I've also improved the type. |
Yeah.. go for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the issue with pasting on mobile, although we can address that in a future PR
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check the code, but UI-wise it's good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the UI, LGTM 👍
Looks good. Merging. 🎉 |
So it looks like the world is not ready for the fast paste approach. Here is a more deterministic solution by @petehunt's idea.
Copy the following data and experiment in the preview.
In this PR
We are adding a third step, but to be honest, in real life we are not a chart replacement and people won't be pasting charts that often, so this is not really annoying as it shows already what is going to be inserted and can keyboard could be used for power users.
Arrow Keys
Tab
key to choose chart (@dwelle)Enter
orSpace
to insert (@dwelle)Possible improvements as we go (if any)
Remember my choice
and don't show this popup again