fix: Allow copy of excalidraw elements only when inside excalidraw

[ad1992]

fixes #3205
Try here

• update changelog

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/2qHwyH64UkWhLNAj5jZjVfxCQKLP
✅ Preview: https://excalidraw-git-aakansha-copy-excalidraw.vercel.app

[dwelle]

I suggest we start with a partial fix (but current solution in this PR is partial anyway), and simply prevent copy if there's an active selection outside the component.

Something like:

if (
	selection?.toString().length &&
    !document.querySelector(".excalidraw")?.contains(selection.anchorNode)
) {
	return
}

This PR will help in this (if we end up merging it) #3207 which should ensure that clicking on canvas deselects external selection.

---

Btw, I was wrong and we do handle copy via the keydown manager.

[ad1992]

Btw, I was wrong and we do handle copy via the keydown manager.

Yes but that also uses copyToClipboard which is the same as copyAll so should be fine right? Or some use case I am missing ?

[dwelle]

Btw, I was wrong and we do handle copy via the keydown manager.

Yes but that also uses copyToClipboard which is the same as copyAll so should be fine right? Or some use case I am missing ?

Yea, I suppose.

But current solution has too many false negatives. E.g. you click on any excalidraw UI, or you click inside wysiwyg and them confirm/cancel via keyboard.

[ad1992]

So any text inside modal was also not getting copied which is also fixed

[ad1992]

So any text inside modal was also not getting copied which is also fixed

For cut the issue still exists so will push the change for cut as well.
No need to worry about this since when using cmd +x it willl use previous copy event so we need not worry and why will someone use cmd+x though :D

[dwelle]

🎉