fix: stop preventing canvas pointerdown/tapend events

[dwelle]

Attempt to fix #3151

Also, this fixes a case where clicking on canvas doesn't deselect selection outside Excalidraw component.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/excalidraw/excalidraw/DUyYkKYSwWckh6GViMR2f2vEs3sr
✅ Preview: https://excalidraw-git-dontpreventcanvaspointerdown-excalidraw.vercel.app

[dwelle]

This actually doesn't work well, as it select text outside the component on canvas double-click. Will investigate.

[dwelle]

So, I kept not preventing default on pointerdown, but had to revert not preventing selection on canvas which was also allowing selecting stuff outside the component.

Unfortunately, this means that clicking on canvas still retains selection that's outside the component. If we need that behavior, we'll need to manually deselect on pointerdown.

[ad1992]

Just need to make sure nothing breaks due to this removal else pr looks good

[dwelle]

Definitely do check. I wouldn't be surprised if something did :).

[ad1992]

I am facing some issues when trying type text, so pointer doesn't change to cursor with single click on canvas, i have to double click.

This works fine in prod.

[dwelle]

I am facing some issues when trying type text, so pointer doesn't change to cursor with single click on canvas, i have to double click.

I "fixed" it by reintroducing the preventDefault in case of text, and manually blurring in any case. Both of these are pretty intertwined with the logic, some of which I'm not sure even how it works.

If we want to keep these hacks it'll mean that the case this PR was supposed to fix (by not preventing the default) will not be 100% fixed (due to the text handling) — well, I think it wouldn't be either way, coz we also prevent default on mobile (touch events) for various reasons.

It could in theory be fixed by delaying (into next event loop tick) binding the wysiwyg blur event.

Ended up hacking the wysiwyg initialization so that our blur event (for submitting the wysiwyg) is bound in a next event loop frame so as to (hopefully) guarantee it fires after the blur event from the pointerdown (which would submit the wysiwyg right away).

I've also made sure we select the element after submit only when confirming the submit via a button. This aligns it with production behavior without having to rely on the preventDefault hack (which was effectively overriding the appState.selectedElementIds with {} afterwards).

[dwelle]

Breaks mobile. Probably related to the other preventDefault calls we do for touch events.

[dwelle]

Removing the preventDefault in onTapEnd handler seems to have fixed the mobile issue (which was preventing wysiwyg submit when clicking outside).