fix: docker build of Excalidraw app #7430
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@agebhar1 is attempting to deploy a commit to the Excalidraw Team on Vercel. A member of the Team first needs to authorize it. |
|
@agebhar1 can you confirm if the updated docker build in this PR works for you ? |
|
As far as I can remember yes @ad1992, but let me check again today. |
agebhar1
force-pushed
the
feature/gh7403-fix-docker-build
branch
from
6561820
to
66bb643
Compare
|
There was a small issue left but now the container is build @ad1992. Also updated to latest version of Nginx. |
|
Any chance to get this PR merged @ad1992? |
|
This should be merged. |
|
since its been long time, @agebhar1 @AlphaCraft9658 can one of you test the build and confirm if this PR is good to go? |
How should I test it? Clone and build, or with GitHub Cl? |
Yes, Running the docker build command locally and testing it out. |
I'll do that on my homelab in a second. |
Cross-env is missing. We should add it to the dev dependencies. |
|
I have done test for locally, see #7430 (review) and https://excalidraw.aolyang.me/ I have used for a time, just try it
|
It doesn't work for me and it says that cross-env is not found. EDIT: I did clone his repository, but his changes are not present. EDIT 2: Oh, wrong branch. |
I tested it. The build succeeds. |
|
Tests are failing. |
@ad1992 ? |
ad1992
force-pushed
the
feature/gh7403-fix-docker-build
branch
from
d984de4
to
efffdfd
Compare
|
Any ETA on when the next release with this fix will be pushed? It should automatically build and push to docker hub, if everything works now, including the publish workflow. |
I will wait for some time to push to release so at max by tomorrow it should be deployed. |
|
The docker build is published 🚀 |
|
I was eager to test this out and can confirm that the Docker image does build. But then I noticed that the build image
I can confirm that |
|
The builder images was not changed with this PR, it's still |
|
My point still stands that the build image ideally should be the same Linux OS as the final image. This just means that the issue has been around longer than the most recent changes. |
|
It's almost an good idea to use the same image IMHO. The build result are only static files which are served by Nginx. Maybe I did not see the issue to serve these files from a different Linux OS. |
Fixes #7403.