Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Docker build (#7582) #7806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcobol
Copy link

@jcobol jcobol commented Mar 23, 2024

Corrected the Dockerfile and .dockerignore to successfully build the excalidraw Docker image locally.

Tested locally by

  • building the Docker image
  • running the image using docker-compose
  • connecting to Excalidraw and using some features

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Mar 23, 2024 5:47pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Mar 23, 2024 5:47pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Mar 23, 2024 5:47pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Mar 23, 2024 5:47pm

@scratchmex
Copy link

I was able to succesfully build the docker image from main with this fix. Thanks.

@dwelle this is a simple fix and I think this issue has been going on for a while. Is there a chance you can get a look into this? Thanks

@modem7
Copy link

modem7 commented Mar 27, 2024

Just an FYI, #7430 also covers fixing the build.

Mostly commenting so that the multiple PR's are linked so the best route forward can be merged.

@mathben
Copy link

mathben commented Mar 29, 2024

I confirm this fix, works for me! Thanks.

@simarmannsingh
Copy link

Wow, this fix works for me for the linux/arm64 platform as well.
Worked like a charm.
This PR should be merged to master, as otherwise the master Docker deployment is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants