-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for mobile devices #787
Conversation
No editing yet, but UI looks nice and you can open the canvas menu
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/vjeux/excalidraw/97as9lt5t |
Looks like tests are failing because I’m using |
Maybe the easier to remove the test until we figure out how to test it properly. |
Nice, thanks so much Jed! I think we should merge this in first, and do all the gesture handling in a second PR. Code looks reasonable. |
|
I’ve given up on getting touch to work now, this should be good to merge |
Testing was carried out on iPhone 11 and iPhone SE simulators. Safe areas (for rounded corners) work as expected, and both portrait and landscape look good. |
Thanks!!!! |
No editing yet, but UI looks nice and you can open the canvas menu
Does not fix #138