Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for mobile devices #787

Merged
merged 6 commits into from
Feb 20, 2020
Merged

Initial support for mobile devices #787

merged 6 commits into from
Feb 20, 2020

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Feb 20, 2020

No editing yet, but UI looks nice and you can open the canvas menu

Does not fix #138

No editing yet, but UI looks nice and you can open the canvas menu
@vercel
Copy link

vercel bot commented Feb 20, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/vjeux/excalidraw/97as9lt5t
✅ Preview: https://excalidraw-git-fork-j-f1-mobile.vjeux.now.sh

@j-f1
Copy link
Member Author

j-f1 commented Feb 20, 2020

@j-f1
Copy link
Member Author

j-f1 commented Feb 20, 2020

One issue is that the color picker doesn’t look too good because it doesn’t flip to point up:

Screenshot_2020-02-20 16 35 15

@j-f1
Copy link
Member Author

j-f1 commented Feb 20, 2020

Looks like tests are failing because I’m using matchMedia, which isn’t supported in the test environment. What should I do?

@lipis
Copy link
Member

lipis commented Feb 20, 2020

Maybe the easier to remove the test until we figure out how to test it properly.

@vjeux
Copy link
Contributor

vjeux commented Feb 20, 2020

Nice, thanks so much Jed!

I think we should merge this in first, and do all the gesture handling in a second PR.

Code looks reasonable.

@j-f1
Copy link
Member Author

j-f1 commented Feb 20, 2020

I’m about to merge in cryptobias#1 so it’ll at least function.

@j-f1
Copy link
Member Author

j-f1 commented Feb 20, 2020

I’ve given up on getting touch to work now, this should be good to merge

@j-f1 j-f1 mentioned this pull request Feb 20, 2020
13 tasks
@j-f1
Copy link
Member Author

j-f1 commented Feb 20, 2020

Testing was carried out on iPhone 11 and iPhone SE simulators. Safe areas (for rounded corners) work as expected, and both portrait and landscape look good.

@vjeux
Copy link
Contributor

vjeux commented Feb 20, 2020

Thanks!!!!

@j-f1 j-f1 deleted the mobile branch February 21, 2020 00:49
@dwelle dwelle mentioned this pull request Feb 21, 2020
@j-f1 j-f1 linked an issue Feb 21, 2020 that may be closed by this pull request
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile support
3 participants