Fix issue #1261 WorkbookWriter sheet.protect() function doesn't exist #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alanscut
reviewed
May 11, 2020
| protect(password, options) { | ||
| // TODO: make this function truly async | ||
| // perhaps marshal to worker thread or something | ||
| return new Promise(resolve => { |
There was a problem hiding this comment.
Whether this attribute should be declared in constructor ().
// worksheet protection
this.sheetProtection = null;There was a problem hiding this comment.
This has been added to the constructor
There was a problem hiding this comment.
Does this really work ? I set sheet protection to true it doesn't lock a particular cell
|
Please merge the current master into your branch |
|
The implementation looks good, but I think we need a better test here. Ideally, write a file with a protection and then show that when reading the file again, the flag is set |
Apologies for the delay, I've updated the test! |
Alanscut
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
protectmethod toworksheet-writer.js(copied fromworksheet.js)