-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #1261 WorkbookWriter sheet.protect() function doesn't exist #1262
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b3ef29b
copying protect method from worksheet.js
65e54c2
copying protect method from worksheet.js
2c7cd20
moving test into pr spec file
d694cf8
renaming file
e36637a
added worksheet protection variable initialization to constructor
a6c1821
Merge branch 'master' of github.com:exceljs/exceljs
7732d11
Merge branch 'master' of github.com:exceljs/exceljs
913d0b5
Merge branch 'master' of github.com:exceljs/exceljs
fb59f28
updated test to read in file and ensure sheet protection is still there.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
const ExcelJS = verquire('exceljs'); | ||
|
||
describe('github issues', () => { | ||
it('pull request 1262 - protect should work with streaming workbook writer', async () => { | ||
const workbook = new ExcelJS.stream.xlsx.WorkbookWriter({ | ||
filename: './test.xlsx', | ||
}); | ||
|
||
const sheet = workbook.addWorksheet('data'); | ||
const row = sheet.addRow(['readonly cell']); | ||
row.getCell(1).protection = { | ||
locked: true, | ||
}; | ||
|
||
expect(sheet.protect).to.exist(); | ||
|
||
sheet.protect('password', { | ||
spinCount: 1, | ||
}); | ||
|
||
await workbook.commit(); | ||
|
||
// read in file and ensure sheetProtection is there: | ||
const checkBook = new ExcelJS.Workbook(); | ||
await checkBook.xlsx.readFile('./test.xlsx'); | ||
|
||
const checkSheet = checkBook.getWorksheet('data'); | ||
expect(checkSheet.sheetProtection.spinCount).to.equal(1); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether this attribute should be declared in
constructor ()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been added to the constructor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really work ? I set sheet protection to true it doesn't lock a particular cell