Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change models to classes and re-arrange folder structure #96

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

ejsmith
Copy link
Member

@ejsmith ejsmith commented Feb 26, 2021

@niemyjski took a pass at changing the models to be classes.

  • Renamed models to not have such generic names like Error that cause issues.
  • Re-arrange the folder structure to organize things a bit better.
  • Something I did saved all single quotes as double quotes, but I actually prefer that and looking around, it seems like that is what the standard is. Is there some reason you picked single quotes?
  • Added some tsdocs on the event model. Would like to get them added throughout the models.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@niemyjski niemyjski merged commit 27afb31 into feature/workspaces Feb 26, 2021
@niemyjski niemyjski deleted the feature/models-to-classes branch February 26, 2021 12:35
niemyjski pushed a commit that referenced this pull request Jun 22, 2021
* Change models to classes and re-arrange folder structure

* Combine error models into single file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants