Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting a tab named the same as default tabs causes it to be unselectable via UI #1289

Closed
Edreih opened this issue Sep 24, 2020 · 3 comments
Assignees
Labels

Comments

@Edreih
Copy link

Edreih commented Sep 24, 2020

Description
When promoting extended data to a tab, the tab cannot be selected via the UI.

Snag_22aba1cd

Investigation
Digging into the source it looks like Angular is targeting the tab by its name with ng-click="vm.activateTab(tab.title)", which there is two of. The tab is not selectable because the extended data tab title is named the same as one of the default Exceptionless tabs.

Workaround
Find the HTML for demoting the tab that is non-selectable, assign it a CSS ID so that it is selectable by JavaScript:

<a ng-click="vm.demoteTab()" id="demote">Demote Tab</a>

Then, in the web console, execute the command to mimic a click to demote the tab.

console.dir(document.getElementById("demote").click());

Then, don't name extended data objects the same as the default ones. Would be better to have tabs selectable by id rather than title?

Hopefully this is useful to any who encounter this. Thanks.

@niemyjski
Copy link
Member

Thanks for reporting this. We could take a look at how these get promoted. I thought when I wrote it I gave tab titles and ids so we could activate by id. But I'm guessing you would have saw that if I did that. I know we only store the name in project settings of promoted tabs. Maybe we could give an id behind the scenes and special case first class ones. Any chance you could take a stab at this?

@niemyjski
Copy link
Member

There are several scenarios we are going to have to think through for this because extended data items all share the same template key so we can't just activate the tab by that.

@niemyjski niemyjski transferred this issue from exceptionless/Exceptionless.UI Mar 6, 2023
niemyjski added a commit that referenced this issue Jul 25, 2023
@niemyjski niemyjski self-assigned this Jul 25, 2023
@niemyjski niemyjski added the bug label Jul 25, 2023
@niemyjski
Copy link
Member

Thanks for reporting this and sorry about taking so long to get this fixed. The latest nightly has a fix for this issue.

niemyjski added a commit that referenced this issue Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants