Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging the UI into the web project #439

Merged
merged 33 commits into from
Mar 2, 2023
Merged

Merging the UI into the web project #439

merged 33 commits into from
Mar 2, 2023

Conversation

ejsmith
Copy link
Member

@ejsmith ejsmith commented Jul 31, 2019

  • Serve the SPA app files from the Web project
  • Automatically start the SPA site (npm run serve) when running the web project
  • Make it so that doing dotnet publish will build the ClientApp and add the files to the output
  • Clean up some old dependencies like puppeteer
  • Automatically use same SSL cert from the ASPNETCORE app
  • Automatically pickup host, port and ssl settings from the ASPNETCORE app
  • Proxy to API so requests can be run on a single domain and doesn't require CORS
  • Single web docker image. Get rid of UI docker image
  • Fix issue with fallback routing not working. Should serve SPA index page when a request comes in that doesn't match an endpoint
  • Make it so that when BaseURL is empty, it calls back to same site
  • Remove client version from bottom of UI. We will have a single version now
  • Update README to explain how to work on the front end without running the back end (set API url)
  • Update README to explain how to work on just the back end without running the front end (change to the Exceptionless API launch profile / remove ASPNETCORE_HOSTINGSTARTUPASSEMBLIES)
  • Update k8s / prod to remove UI service and use combined Web / UI instead

@ejsmith ejsmith marked this pull request as ready for review February 27, 2023 17:03
@ejsmith ejsmith changed the title WIP: Experimenting with merging the UI into the web project Merging the UI into the web project Feb 27, 2023
niemyjski
niemyjski previously approved these changes Mar 1, 2023
Copy link
Member

@niemyjski niemyjski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some minor client side issues I left comments on.

packages/.gitignore Show resolved Hide resolved
src/Exceptionless.Web/ClientApp/app.config.js Outdated Show resolved Hide resolved
@ejsmith ejsmith merged commit ce20e74 into main Mar 2, 2023
@ejsmith ejsmith deleted the feature/merge-ui branch March 2, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants