-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging the UI into the web project #439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejsmith
force-pushed
the
feature/merge-ui
branch
from
August 31, 2019 08:05
d2d151a
to
3c4a4e1
Compare
ejsmith
force-pushed
the
feature/merge-ui
branch
from
March 7, 2020 01:21
3c4a4e1
to
59c649b
Compare
ejsmith
force-pushed
the
feature/merge-ui
branch
from
March 25, 2020 01:40
59c649b
to
26dde3e
Compare
ejsmith
force-pushed
the
feature/merge-ui
branch
from
November 2, 2020 01:47
26dde3e
to
515f0b3
Compare
ejsmith
force-pushed
the
feature/merge-ui
branch
from
February 26, 2023 06:14
4d79142
to
5aa059b
Compare
ejsmith
changed the title
WIP: Experimenting with merging the UI into the web project
Merging the UI into the web project
Feb 27, 2023
…ent for each and also so there isn't more than one project in the root.
niemyjski
previously approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just some minor client side issues I left comments on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run serve
) when running the web projectdotnet publish
will build theClientApp
and add the files to the outputBaseURL
is empty, it calls back to same site