Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple server configuration: #22

Closed
wants to merge 2 commits into from
Closed

Allow multiple server configuration: #22

wants to merge 2 commits into from

Conversation

scamille
Copy link

@scamille scamille commented Jun 8, 2014

SERVER, PORT, PASSWD are now specified as a list of tuples.

Add some debug messages for connection failures/sucess.

SERVER, PORT, PASSWD are now specified as a list of tuples.

Add some debug messages for connection failures/sucess.
@excid3
Copy link
Owner

excid3 commented Jun 8, 2014

I like the direction you're going but I think it would make sense not to fork our own version of IRClib and instead upgrade to the latest version of it. https://bitbucket.org/jaraco/irc/src

It looks like it has fairly heavily changed since I started the logbot though. Up for the challenge?

@scamille
Copy link
Author

scamille commented Jun 8, 2014

Thanks for the quick reply. I didn't realize you worked with a unmodified IRClib, and I can see how forking it compromises adaptability.

I'll think about doing the upgrading to the new IRClib version. Main challenge is as usual to find enough time to do it, so I can't promise anything ;)

I guess we can close this Pull Request then for now.

@excid3
Copy link
Owner

excid3 commented Jun 8, 2014

It's all good. If you get time that would be awesome to see.

I think I will create a new issue in reference to this in case anyone else comes across this and wants to upgrade it.

@excid3 excid3 closed this Jun 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants