implement password_challenge
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a new parameter provided by `has_secure_password` that's available in Rails 7.1
kylekeesling
force-pushed
the
password-challenge
branch
from
477c328
to
b0fdf84
Compare
|
It's been a minute since I've looked at this, but I'm happy to update it now that 7.1 is on the horizon if you'd still find it useful! |
kylekeesling
force-pushed
the
password-challenge
branch
from
23fe142
to
dc52b6c
Compare
excid3
reviewed
Sep 27, 2023
| @@ -43,8 +43,8 @@ | |||
| <% end %> | |||
|
|
|||
| <div> | |||
| <%= label_tag :current_password %> | |||
| <%= password_field_tag :current_password, nil, required: true %> | |||
| <%= form.label :password_challenge, "Current password" %> | |||
There was a problem hiding this comment.
Just realized, I guess we should probably localize these views in another PR.
excid3
reviewed
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the Rails 7.1 feature that allows you to provide a
password_challengealong withpasswordandpassword_confirmationparams to do a password check prior to updating the record.Closes #21 and redo of #22.