Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need a way to rewind responses for idempotent requests. #657

Closed
maf23 opened this issue Dec 11, 2017 · 3 comments
Closed

Need a way to rewind responses for idempotent requests. #657

maf23 opened this issue Dec 11, 2017 · 3 comments

Comments

@maf23
Copy link

maf23 commented Dec 11, 2017

There needs to be a way to know when an idempotent request is restarted. Excon may already have returned some blocks of data before it encountered an error so the caller must be able to get notified that the request is restarted. Analogous to the rewind in the request block.

This is needed by fog: fog/fog-xml#13
@maf23 maf23 mentioned this issue Dec 11, 2017
Closed
@geemus geemus closed this as completed in 8fd633e Dec 14, 2017
@geemus
Copy link
Contributor

geemus commented Dec 14, 2017

@maf23 I think this is what we want, but would love it if you could review and confirm, thanks!

@maf23
Copy link
Author

maf23 commented Dec 15, 2017

It looks good to me.

@geemus
Copy link
Contributor

geemus commented Dec 15, 2017 via email

maf23 added a commit to maf23/fog-xml that referenced this issue Mar 6, 2018
@maf23
Use the new method to rewind responses created in excon/excon#657
47d8a61
@maf23 maf23 mentioned this issue Mar 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geemus @maf23