Don't create window.WebServer.

It was done for WebPage for backward compatibility and it would be removed in the future, so don't do it for WebServer. http://code.google.com/p/phantomjs/issues/detail?id=115
execjosh · Dec 23, 2011 · cbc9be0 · cbc9be0
1 parent 1ee0a4c
commit cbc9be0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/bootstrap.js b/src/bootstrap.js
@@ -55,4 +55,3 @@ function require(name) {
 
 // Legacy way to use WebPage
 window.WebPage = require('webpage').create;
-window.WebServer = require('webserver').create;
diff --git a/test/webserver-spec.js b/test/webserver-spec.js
@@ -1,10 +1,11 @@
 describe("WebServer constructor", function() {
-    it("should exist in window", function() {
-        expect(window.hasOwnProperty('WebServer')).toBeTruthy();
+    it("should not exist in window", function() {
+        expect(window.hasOwnProperty('WebServer')).toBeFalsy();
     });
 
     it("should be a function", function() {
-        expect(typeof window.WebServer).toEqual('function');
+        var WebServer = require('webserver').create;
+        expect(typeof WebServer).toEqual('function');
     });
 });
 
@@ -31,7 +32,7 @@ function checkRequest(request, response) {
 }
 
 describe("WebServer object", function() {
-    var server = new WebServer();
+    var server = require('webserver').create();
 
     it("should be creatable", function() {
         expect(typeof server).toEqual('object');