Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This FC addon needs a legit svg icon for the FC AddonManager #27

Closed
luzpaz opened this issue Jul 26, 2019 · 5 comments · Fixed by FreeCAD/FreeCAD#2403
Closed

This FC addon needs a legit svg icon for the FC AddonManager #27

luzpaz opened this issue Jul 26, 2019 · 5 comments · Fixed by FreeCAD/FreeCAD#2403

Comments

@luzpaz
Copy link
Contributor

luzpaz commented Jul 26, 2019

We bundle the FreeCAD-addons workbench/addons SVG icons within FC. Once you add it to this repo, I'll copy it in to master.
@execuc
Copy link
Owner

execuc commented Aug 1, 2019

Thanks for the integration of this module in freecad.
To understand what I need to do, I have to make an icon for this module in SVG to replace the 16x16 xpm icon ?

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 1, 2019 •
edited

not replace just have an svg version as well

execuc added a commit that referenced this issue Aug 5, 2019
@execuc
Create addon_icon.svg
c225e8a 
#27 : Add SVG icon for the Freecad addon manager.
@execuc
Copy link
Owner

execuc commented Aug 5, 2019

I added icon at base directory ("addon_icon.svg"). Could you tell me if that's okay ?

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 5, 2019

It looks good but the size of the file is pretty large. Take for example other workbench icons in:
https://github.com/FreeCAD/FreeCAD/tree/master/src/Mod/AddonManager/Resources/icons

execuc added a commit that referenced this issue Aug 5, 2019
@execuc
Create small_icon.svg
6625bde 
#27 Add smaller icon for addon
@execuc
Copy link
Owner

execuc commented Aug 5, 2019

OK. I made a smaller one.

luzpaz added a commit to luzpaz/FreeCAD that referenced this issue Aug 6, 2019
@luzpaz
[AddonManager] Add LCInterlocking icon
8111d76 
Closes execuc/LCInterlocking#27
@luzpaz luzpaz mentioned this issue Aug 6, 2019
Merged
@luzpaz luzpaz closed this as completed Aug 6, 2019
yorikvanhavre pushed a commit to FreeCAD/FreeCAD that referenced this issue Aug 9, 2019
@luzpaz @yorikvanhavre
[AddonManager] Add LCInterlocking icon
3799aff 
Closes execuc/LCInterlocking#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AddonManager] Add and modify several Addon/Workbench icons luzpaz/FreeCAD
2 participants
@luzpaz @execuc