Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

could you make a release ? #543

Closed
12rambau opened this issue Sep 18, 2023 · 17 comments
Closed

could you make a release ? #543

12rambau opened this issue Sep 18, 2023 · 17 comments
Labels
bug Something isn't working

Comments

@12rambau
Copy link

12rambau commented Sep 18, 2023 •
edited

V0.17.2 is still blocked on Sphinx<6 making many pipelines (including pydata-sphinx-theme) crash
@12rambau 12rambau added the bug Something isn't working label Sep 18, 2023
@welcome
Copy link

welcome bot commented Sep 18, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@12rambau 12rambau mentioned this issue Sep 18, 2023
Closed
@agoose77
Copy link
Collaborator

We're working through some parts of the CI pipeline, and one these are fixed, we'll make a release!

@drammock drammock mentioned this issue Sep 19, 2023
Merged
@cisaacstern
Copy link

V0.17.2 is still blocked on Sphinx<6 making many pipelines (including pydata-sphinx-theme) crash

+1 on this exact issue. Trying to update our Pangeo Forge docs in pangeo-forge/pangeo-forge-recipes#610 is also blocked by this. Will very much appreciate a release as soon as you are able. 🙏

@cisaacstern
Copy link

We're working through some parts of the CI pipeline, and one these are fixed, we'll make a release!

@agoose77 is there an open Issue or PR for this? Would be curious to see if there's some way I can assist, or at least follow along with the progress.

@peytondmurray peytondmurray mentioned this issue Sep 26, 2023
Closed
@junpenglao junpenglao mentioned this issue Sep 27, 2023
Merged
@trallard trallard mentioned this issue Sep 27, 2023
Closed
@speth speth mentioned this issue Oct 3, 2023
Merged
5 tasks
@frank1010111 frank1010111 mentioned this issue Oct 8, 2023
Closed
@renefritze renefritze mentioned this issue Oct 9, 2023
Closed
@peytondmurray
Copy link
Contributor

peytondmurray commented Oct 9, 2023 •
edited

I'd really like to help out in any way I can to push this issue forward, but I'd really like to avoid spamming the maintainers in the process. It looks like the one remaining issue here is a typo that is aggravating pre-commit:

image

Normally I'd prefer not to make PRs related to this kind of thing. Seeing as how it is holding up a release, I'd be happy to do so here if it means we can get a release out.

@agoose77
Copy link
Collaborator

agoose77 commented Oct 9, 2023

My bandwidth is pretty tied up this week. AFAICR, we're just needing to fix-up some type hints, and then we're good to go.

@peytondmurray
Copy link
Contributor

Sounds good - if you point me in the direction of a specific issue, I can take care of it, though it looks like mypy is currently passing. I'd be happy to include the fix for the typo above in whatever else needs to be done.

@henry2004y henry2004y mentioned this issue Oct 16, 2023
Merged
@PhilipVinc
Copy link

@agoose77 I think the repo's ready for a new release now. Could you tag 0.18?

@njzjz
Copy link

njzjz commented Oct 20, 2023 •
edited

If 0.18.0 is not available, could you tag 0.18.0b0?

@njooma njooma mentioned this issue Oct 23, 2023
Merged
ChristosT added a commit to ChristosT/pyansys-geometry that referenced this issue Oct 24, 2023
@ChristosT
docs: Bring myst_nb
0a4b700 
myst_nb parser allows to parse cell tags. Currently we use an unreleased version.
Clone from https://github.com/executablebooks/MyST-NB and pip install -e . into the enviroment of the documentation generation.
See also executablebooks/MyST-NB#543
ChristosT added a commit to ChristosT/pyansys-geometry that referenced this issue Oct 25, 2023
@ChristosT
docs: Bring myst_nb
e299689 
myst_nb parser allows to parse cell tags. Currently we use an unreleased version.
Clone from https://github.com/executablebooks/MyST-NB and pip install -e . into the environment of the documentation generation.
See also executablebooks/MyST-NB#543
@ChristosT ChristosT mentioned this issue Oct 25, 2023
Closed
@sphuber
Copy link

sphuber commented Oct 25, 2023

A new release would be great as it would also loosen the requirement on myst-parser to >=0.18.0 which is necessary to be able to install 2.0.0 which is required for compatibility with Python 3.12

@michaelweinold michaelweinold mentioned this issue Oct 25, 2023
Merged
@sphuber sphuber mentioned this issue Oct 25, 2023
Merged
@agoose77
Copy link
Collaborator

Hi all - could you try out https://pypi.org/project/myst-nb/1.0.0rc0/?

@sphuber
Copy link

sphuber commented Oct 25, 2023

Works for our build of AiiDA 👍 thanks a lot!

@cisaacstern cisaacstern mentioned this issue Oct 25, 2023
Merged
@cisaacstern
Copy link

Thanks @agoose77! LGTM over in pangeo-forge/pangeo-forge-recipes#641 👍

@PhilipVinc
Copy link

@agoose77 I tested the rc0 on our documentation of https://readthedocs.org/projects/netket/and it works great. We're just waiting for an official release of 1.0.0 to update our infrastructure.

@jakevdp
Copy link
Contributor

jakevdp commented Nov 2, 2023

I tested rc0 on the documentation build for http://github.com/google/jax, and everything looks fine. Thanks for all the work on this package!

@blakeNaccarato
Copy link

Thanks for releasing v1.0.0! Looks like this issue may be able to be closed now.

It seems there isn't a changelog entry yet, but from the diff (v0.17.2...v1.0.0), the biggest user-facing changes seem to be Sphinx 7 support, bumping minimum myst-parser to 1.0, removing upper version pins in requirements, and bumping minimum Python to 3.9. Are there any other major changes to watch out for when updating? Thanks again!

@agoose77
Copy link
Collaborator

agoose77 commented Dec 4, 2023

This has now been handled!

@blakeNaccarato you're correct that the major changes are removing caps, bumping dependencies, and adding Sphinx 7 support. :)

@agoose77 agoose77 closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@jakevdp @agoose77 @PhilipVinc @sphuber @njzjz @12rambau @peytondmurray @blakeNaccarato @cisaacstern