Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option / config for analytics tracking? #115

Closed
TomDonoghue opened this issue Feb 25, 2019 · 2 comments · Fixed by #116
Closed

Add an option / config for analytics tracking? #115

TomDonoghue opened this issue Feb 25, 2019 · 2 comments · Fixed by #116
Labels
enhancement New feature or request

Comments

@TomDonoghue
Copy link
Contributor

Would it be easy to add, in the notebook / config options, a way to add analytics / audience data, for example with Google Analytics? It's a while since I've set this up, but I think just adding a field in the config that people can fill in with google analytics ID might get most of the way there.

I've been meaning to add this to the books I have hosted, and just figured it could be something useful to add upstream - so thought I'd ask! I can look into this a bit more at some point - but just thought someone here might know quickly how to do this.

@choldgraf
Copy link
Member

totally agree - I think it'd be great to make this possible. It'd need:

  1. A little html in includes to include the GA snippet
  2. A new configuration key like google_analytics: mytrackingcode.
  3. Some short documentation explaining how to enable it, and linking to the GA code for generating your own analytics key

I'm happy to review a PR if you have a moment to try it out!

@choldgraf choldgraf added the enhancement New feature or request label Feb 25, 2019
@joergbrech
Copy link
Contributor

I have done something like this in my own jupyter book copy, I am happy to contribute.

joergbrech added a commit to joergbrech/jupyter-book that referenced this issue Feb 26, 2019
joergbrech added a commit to joergbrech/jupyter-book that referenced this issue Feb 26, 2019
joergbrech added a commit to joergbrech/jupyter-book that referenced this issue Feb 26, 2019
Add some documentation for executablebooks#115
joergbrech added a commit to joergbrech/jupyter-book that referenced this issue Mar 26, 2019
joergbrech added a commit to joergbrech/jupyter-book that referenced this issue Mar 26, 2019
joergbrech added a commit to joergbrech/jupyter-book that referenced this issue Mar 26, 2019
Add some documentation for executablebooks#115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants