Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: prepare for 1.0 release #2089

Merged
merged 52 commits into from Jan 25, 2024
Merged

MAINT: prepare for 1.0 release #2089

merged 52 commits into from Jan 25, 2024

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Dec 11, 2023

This PR bumps our various EB dependencies, updates Sphinx pinning!

docs/_config.yml Outdated Show resolved Hide resolved
@choldgraf
Copy link
Member

Sounds good - just a reminder that the book theme is still only in pre-release form, we gotta make a proper release of that one soon. I don't think we've got any reports of bugs etc so unless there's a clear reason to hold off I'd be +1 on making a full release there.

@agoose77
Copy link
Collaborator Author

@choldgraf agreed. It will take another day to make this ready for a release I suspect; need to figure out the dependency story (docutils is broken for multiple versions w.r.t sphinxcontrib-bibtex).

Pushing through slowly ...

@mmcky
Copy link
Member

mmcky commented Dec 11, 2023

@agoose77 let me know if you need any help with sphinx-jupyterbook-latex (cc: @AakashGfude)

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6b0275a) 91.48% compared to head (8481ec9) 91.30%.
Report is 37 commits behind head on master.

Files Patch % Lines
jupyter_book/cli/main.py 71.42% 2 Missing ⚠️
jupyter_book/config.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2089      +/-   ##
==========================================
- Coverage   91.48%   91.30%   -0.19%     
==========================================
  Files           7        7              
  Lines         693      690       -3     
==========================================
- Hits          634      630       -4     
- Misses         59       60       +1     
Flag Coverage Δ
pytests 91.30% <75.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agoose77
Copy link
Collaborator Author

@choldgraf this PR is finally done. Here are the highlights:

  • Only support sphinx==5 and sphinx>=7
    • This follows because sphinxcontrib-bibtex is a required dependency, and it breaks for docutils==0.18.*,==0.19.*
  • Drop python_version<=3.8.*, support python_version>=3.9,<=3.12
  • Unpin any non-EB dependencies (and pin EB dependencies to major versions for now)
  • Add config options for new developments in myst-nb etc.

I think we're ready for a release?

@agoose77 agoose77 merged commit fc1f51c into master Jan 25, 2024
15 of 16 checks passed
@agoose77
Copy link
Collaborator Author

I'm going to merge this in, and then we can go from there :)

@agoose77 agoose77 mentioned this pull request Jan 25, 2024
@rowanc1 rowanc1 deleted the agoose77/maint-prepare-1.0 branch January 25, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants