-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump docutils #2048
bump docutils #2048
Conversation
- partially reverts executablebooks#1965 - fixes executablebooks#1970 - fixes executablebooks#1997 - fixes executablebooks#2022 - fixes executablebooks#2026 - fixes executablebooks#2037
Thanks for submitting your first pull request! You are awesome! 🤗 |
- TODO: revert after executablebooks/jupyter-book#2048
- TODO: revert after executablebooks/jupyter-book#2048
c8bee85
to
0661811
Compare
"Jinja2", | ||
"jsonschema<5", | ||
"linkify-it-py~=2.0.0", | ||
"myst-nb~=0.17.1", | ||
"pyyaml", | ||
"sphinx>=4,<6", | ||
"sphinx>=4,!=6.*,!=7.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or perhaps
"sphinx>=4,!=6.*,!=7.0.0", | |
"sphinx>=4,!=6.*,!=7.0.0,<8", |
Note that sphinx==7.0.1
is the first version which permits docutils>0.19
(vis. sphinx-doc/sphinx#11411).
However I don't know if it breaks jupyter-book
. This needs testing :)
- TODO: revert after executablebooks/jupyter-book#2048
- TODO: revert after executablebooks/jupyter-book#2048
@casperdcl thank you so much for all of this work. I think it's been superseded by #2089, but your efforts are really appreciated. I'm sorry that we didn't get this in as-is: maintainer time had been low before Christmas, and we just didn't have the bandwidth. I look forward to any contributions you have in future <3 |
Allow
docutils>=0.20
, which includes the patch from https://sourceforge.net/p/docutils/patches/195docutils
need to be upgraded #2037Though technically a similar PR to bump
docutils
will be required in https://github.com/sphinx-doc/sphinx and https://github.com/executablebooks/MyST-Parser to really fix the above issues.EDIT: thanks to sphinx-doc/sphinx#11411 it seems we also need
sphinx>=7.0.1
here... is that feasible?