Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on jupyter-server #177

Closed
wants to merge 1 commit into from

Conversation

jtpio
Copy link

@jtpio jtpio commented Aug 17, 2023

This should fix the installation issue with JupyterLite as reported in jupyterlite/jupyterlite#1122.

@welcome
Copy link

welcome bot commented Aug 17, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/jupyterlab-myst/jupyter-server-dep

@agoose77
Copy link
Collaborator

agoose77 commented Aug 17, 2023

@jtpio as Python packaging doesn't have peerDependencies like npm does, I'd like to specify the dependency somehow. The same, of course, is true for the jupyterlab version (which we don't currently specify). I wonder if splitting the server component into a separate package would help. We could then potentially use sys_platform to test for emscripten.

@jtpio do you have any feelings about whether it's appropriate to use publish PyPI wheels that sys_platform to detect emscripten? I can't find any standard on the allowed values for sys_platform, which implies it's OK.

@agoose77
Copy link
Collaborator

@jtpio thinking about this again - would changing this dependency to jupyterlab instead of jupyter-server work for jupyterlite?

@jtpio
Copy link
Author

jtpio commented Aug 28, 2023

would changing this dependency to jupyterlab instead of jupyter-server work for jupyterlite?

It would be quite similar since jupyterlab depends on jupyter-server.

@agoose77
Copy link
Collaborator

Closed by f0720a1

@agoose77 agoose77 closed this Aug 29, 2023
@jtpio jtpio deleted the jupyter-server-dep branch August 29, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants