Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jupyterlab-myst (tornado), or remove from build #1122

Closed
mattcen opened this issue Aug 12, 2023 · 5 comments · Fixed by #1263
Closed

Fix jupyterlab-myst (tornado), or remove from build #1122

mattcen opened this issue Aug 12, 2023 · 5 comments · Fixed by #1263
Labels
bug Something isn't working

Comments

@mattcen
Copy link

mattcen commented Aug 12, 2023

Description

jupyterlab-myst is included by 3217ae2, but when trying to install it, I get an error about failure to find a suitable build of tornado:

Reproduce

%pip install jupyterlab-myst
ValueError: Can't find a pure Python 3 wheel for 'tornado>=6.2.0'.
See: https://pyodide.org/en/stable/usage/faq.html#micropip-can-t-find-a-pure-python-wheel
You can use `micropip.install(..., keep_going=True)`to get a list of all packages with missing wheels.

Expected behavior

jupyterlab-myst installs successfully

Context

@mattcen mattcen added the bug Something isn't working label Aug 12, 2023
@jtpio
Copy link
Member

jtpio commented Aug 17, 2023

Thanks @mattcen for reporting.

jupyterlab-myst used to be working with JupyterLite fine at some point: #1021

This issue likely comes from the dependency on jupyter_server: https://github.com/executablebooks/jupyterlab-myst/blob/23d2aba01353f02843cb298dd0361ff1b45b01db/pyproject.toml#L25

Which was added in executablebooks/jupyterlab-myst#155

In the meantime we might want to pin on an earlier version, for example jupyterlab-myst<2.

@jtpio
Copy link
Member

jtpio commented Aug 17, 2023

Pinning on jupyterlab-myst<2 should help for now, and is also recommended until there is a new release of JupyterLite using the JupyterLab 4 packages (#1019):

image

@agoose77
Copy link
Contributor

Fixed by jupyterlab-myst>=2.0.2

@jtpio
Copy link
Member

jtpio commented Aug 29, 2023

Nice!

Maybe we can bump the extension here:

"https://conda.anaconda.org/conda-forge/noarch/jupyterlab-myst-0.1.6-pyhd8ed1ab_0.tar.bz2",

@agoose77
Copy link
Contributor

Oh, I hadn't quite internalised that jupyterlite isn't yet on 4.0. That PR will have to wait for a bit, it seems :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants