Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃憣 IMPROVE: Defaut HTML tags #4

Merged
merged 4 commits into from
Sep 9, 2021
Merged

馃憣 IMPROVE: Defaut HTML tags #4

merged 4 commits into from
Sep 9, 2021

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Jul 6, 2021

Changed the default parsing to: <div class="math amsmath">{content}</div>. See #1

Added some tests to cover more realistic AMS math scenarios.

Also in this PR: Added a prettier ignore file, updated the package lock with the peer dependencies.

@welcome
Copy link

welcome bot commented Jul 6, 2021

Thanks for submitting your first pull request! You are awesome! 馃

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 馃帀

@rowanc1 rowanc1 changed the base branch from master to main July 6, 2021 04:24
@chrisjsewell
Copy link
Member

I will wait to see the corresponding PR on mdit-py-plugins before approving this 馃槈

@rowanc1
Copy link
Member Author

rowanc1 commented Aug 3, 2021

I will wait to see the corresponding PR on mdit-py-plugins before approving this 馃槈

The changes have been made in: executablebooks/mdit-py-plugins#27

@chrisjsewell chrisjsewell linked an issue Sep 9, 2021 that may be closed by this pull request
@chrisjsewell chrisjsewell changed the title 馃敡 MAINTAIN: HTML default tags 馃憣 IMPROVE: Defaut HTML tags Sep 9, 2021
@chrisjsewell chrisjsewell merged commit b4d6c24 into main Sep 9, 2021
@welcome
Copy link

welcome bot commented Sep 9, 2021

Congrats on your first merged pull request in this project! 馃帀
congrats

Thank you for contributing, we are very proud of you! 鉂わ笍

@chrisjsewell chrisjsewell deleted the ref/html-defaults branch September 9, 2021 23:08
@rowanc1
Copy link
Member Author

rowanc1 commented Sep 9, 2021

Nice, thanks for the merge!

@chrisjsewell
Copy link
Member

I'm bloody on it lol!
Going to try and push through all the JS stuff right now; ah the world has been conspiring against me lol had some heavy "man flu" this week 馃

If you are mildly interested in what has been keeping me away from EBP, things like this: https://github.com/chrisjsewell/aiida-process-coordinator; basically if you need any help with sockets, or servers, or databases, ... let me know lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default HTML tags
2 participants