Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃憣 IMPROVE: AMSmath defaut HTML tags #27

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Aug 3, 2021

Changed the default rendering to: <div class="math amsmath">{content}</div>.

Added some tests to cover more realistic AMS math scenarios.

See also:
executablebooks/markdown-it-amsmath#4
executablebooks/markdown-it-amsmath#1

@welcome
Copy link

welcome bot commented Aug 3, 2021

Thanks for submitting your first pull request! You are awesome! 馃

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 馃帀

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #27 (bbcb101) into master (a0f7ffa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files          24       24           
  Lines        1215     1215           
=======================================
  Hits         1135     1135           
  Misses         80       80           
Flag Coverage 螖
pytests 93.41% <100.00%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
mdit_py_plugins/amsmath/__init__.py 95.45% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update a0f7ffa...bbcb101. Read the comment docs.

@chrisjsewell chrisjsewell changed the title 馃敡 MAINTAIN: HTML default tags 馃憣 IMPROVE: AMSmath defaut HTML tags Sep 9, 2021
@chrisjsewell chrisjsewell merged commit c14b8fa into master Sep 9, 2021
@welcome
Copy link

welcome bot commented Sep 9, 2021

Congrats on your first merged pull request in this project! 馃帀
congrats

Thank you for contributing, we are very proud of you! 鉂わ笍

@chrisjsewell chrisjsewell deleted the ref/html-defaults branch September 9, 2021 23:05
chrisjsewell pushed a commit to executablebooks/markdown-it-amsmath that referenced this pull request Sep 9, 2021
Changes the default parsing to: `<div class="math amsmath">{content}</div>`
This produces better default HTML,
for rendering by "post-process" JS.

Also, added some tests to cover more realistic AMS math scenarios.

This is inline with: executablebooks/mdit-py-plugins#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants