-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: specify release bound for compat test #258
base: master
Are you sure you want to change the base?
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #258 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 62 62
Lines 3236 3236
=======================================
Hits 3109 3109
Misses 127 127
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work, although my opinion is that support for alpha/beta releases should not be expected, so perhaps not worth it to further complicate the tuple comparison with non-integer values?
Co-authored-by: Taneli Hukkinen <3275109+hukkin@users.noreply.github.com>
I agree with the principle, but in this case I feel that the extra code is not that much more complex to justify not making this change? I'll defer to your final judgement though — merge this if you're happy, close if not! :) |
I didn't bisect to find when 3.10 adds the
slots
argument; I know it's in the release itself, and I don't think we need to be that careful to provide features to old alpha/beta/rc releases.