Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'$'-delimited in-line math example fails in syntax.md #51

Closed
rossbar opened this issue Feb 18, 2020 · 6 comments · Fixed by #59 or #66
Closed

'$'-delimited in-line math example fails in syntax.md #51

rossbar opened this issue Feb 18, 2020 · 6 comments · Fixed by #59 or #66
Assignees
@chrisjsewell
Labels
bug Something isn't working

Comments

@rossbar
Copy link
Contributor

rossbar commented Feb 18, 2020

The $-delimited math on line 352 of syntax.md doesn't render properly at build.

Other instances of $-delimited inline math in the file seem to work though, not sure why this particular instance is not working.

N.B. switching to the myst-role syntax {math}... works fine.
@chrisjsewell chrisjsewell added the bug Something isn't working label Feb 18, 2020
@chrisjsewell
Copy link
Member

Thanks @rossbar I'll look into it

@chrisjsewell chrisjsewell self-assigned this Feb 18, 2020
@rossbar
Copy link
Contributor Author

rossbar commented Feb 18, 2020

Are bug reports along these lines valuable? I'm in the process of translating some open-source text book material into myst format (which is fantastic BTW) for testing and I'm sure I will come across other issues. I can open issues here to keep things centralized, but I don't want to spam the repo with a bunch of potentially-low-priority issues. I'm happy to keep issues in a different repo/fork. LMK your preference!

@chrisjsewell
Copy link
Member

Are bug reports along these lines valuable?

Oh yeh they are super useful thanks 😄

I don't want to spam the repo with a bunch of potentially-low-priority issues

If you go to add an issue now you will see options for adding 'Bug Reports' or 'Feature Requests', these will auto categorize the issues etc, so they are easier to deal with. Spam away!

chrisjsewell added a commit that referenced this issue Feb 19, 2020
@chrisjsewell
Add Markdown syntax parsing tests
9162fe3 
Also move front_matter YAML block parsing to renderers and fix #51
@chrisjsewell chrisjsewell mentioned this issue Feb 19, 2020
Merged
chrisjsewell added a commit that referenced this issue Feb 19, 2020
@chrisjsewell
Restructure testing and directive block parsing (#59)
1a1cd05 
In this PR I have:

1. Restructured the test folder and added an `AstRenderer` and lower level tests for the source text to Markdown (mistletoe) AST.
2. Added `docs/develop/test_infrastructure.md` to explain the testing inrastructure.
3. Restructured the directive block parsing, to make it more modular/understandable and improved error checking and reporting.

fixes #54, fixes #55, fixes #51
@chrisjsewell
Copy link
Member

@rossbar this should be fixed in the last commit, but please reopen if you still encounter a problem

@rossbar
Copy link
Contributor Author

rossbar commented Feb 19, 2020

@chrisjsewell it appears I can't re-open the issue so I'll just comment: line 365 from doc/using/syntax.md is still not properly rendering the in-line, '$'-delimited math in the html as of 1a1cd05

@choldgraf choldgraf reopened this Feb 19, 2020
@chrisjsewell chrisjsewell mentioned this issue Feb 20, 2020
Merged
@chrisjsewell
Copy link
Member

@rossbar actually fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisjsewell chrisjsewell

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@rossbar @choldgraf @chrisjsewell