🛠 fix for empty blocks in notebooks (#134)

* 👽 empty markdown cells get an empty string as source --------- Co-authored-by: Rowan Cockett <rowanc1@gmail.com>
executablebooks · Jun 21, 2023 · beee0d6 · beee0d6
1 parent fe1408b
commit beee0d6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/friendly-cooks-dream.md b/.changeset/friendly-cooks-dream.md
@@ -0,0 +1,5 @@
+---
+'@myst-theme/jupyter': patch
+---
+
+Patch myst-block bug
diff --git a/packages/jupyter/src/providers.tsx b/packages/jupyter/src/providers.tsx
@@ -83,7 +83,7 @@ export function notebookFromMdast(
   // Object.assign(notebook.metadata, ipynb.metadata);
   notebook.cells = (mdast.children as GenericParent[]).map((block: GenericParent) => {
     if (block.type !== 'block') console.warn(`Unexpected block type ${block.type}`);
-    if (block.children.length == 2 && block.children[0].type === 'code') {
+    if (block.children && block.children.length == 2 && block.children[0].type === 'code') {
       const [codeCell, output] = block.children;
 
       // use the block.key to identify the cell but maintain a mapping
@@ -105,7 +105,7 @@ export function notebookFromMdast(
       const cell = new core.ThebeNonExecutableCell(
         block.key,
         notebook.id,
-        block.children.reduce((acc, child) => acc + '\n' + (child.value ?? ''), ''),
+        block.children?.reduce((acc, child) => acc + '\n' + (child.value ?? ''), '') ?? '',
         block.data ?? {},
         notebook.rendermime,
       );