馃洜 fix for empty blocks in notebooks #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanc1
reviewed
Jun 21, 2023
packages/jupyter/src/providers.tsx
Outdated
| @@ -105,7 +105,7 @@ export function notebookFromMdast( | |||
| const cell = new core.ThebeNonExecutableCell( | |||
| block.key, | |||
| notebook.id, | |||
| block.children.reduce((acc, child) => acc + '\n' + (child.value ?? ''), ''), | |||
| block.children?.reduce((acc, child) => acc + '\n' + (child.value ?? ''), ''), | |||
There was a problem hiding this comment.
I think the if-statement will also fall through to here. This will mean that the content is undefined?
Is that fine? I am not sure what the ThebeNonExecutableCell does in this case!
There was a problem hiding this comment.
nice catch -- the no children condition only occurs with empty markdown (both code and raw cells have children) cells, so we want to create the non executable cell with an empty source string in that case
|
Nice -- glad that you found the source of this, makes sense I think, I will make an issue upstream to ensure that blocks have a children list always as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this caused a runtime error in notebook processing from mdast