Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘©πŸ½β€πŸ« Initial support for proofs and theorems #87

Merged
merged 1 commit into from May 13, 2023

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented May 13, 2023

Based on sphinx-proof

See: executablebooks/mystmd#384

@rowanc1 rowanc1 merged commit 98b7704 into main May 13, 2023
1 check passed
@rowanc1 rowanc1 deleted the feat/proof branch May 13, 2023 23:18
'm-0 font-medium py-2 flex min-w-0',
'text-md',
'',
'border-y dark:border-y-0 dark:border-l-4 border-slate-400',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So (this is great btw) the dark:border-l-4 here causes a small misalignment. To fix it either dark:ml-3 is needed on L164 below, or else dark:border-l-4 should be moved up to the WrapperElement. I prefer the latter solution for parity with dark admonitions.

I tried to do it myself but it results in the wrong border color and I'm not sure how to fix that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok -- first attempt is in #90, I misread this comment though and see now you were thinking proofs should be more like admonitions. I went back and forth on this in my first pass and decided to make them a bit different intentionally, but not a lot of reason behind that.

I will explore this now and post a screenshot of options.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think I do like this better!

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it better too, I think -- meaning w/ the long border. I am not sure whether the original border color was nicer... though not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants