Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Alignment of proof header #90

Merged
merged 3 commits into from
May 15, 2023
Merged

🎨 Alignment of proof header #90

merged 3 commits into from
May 15, 2023

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented May 14, 2023

Thanks @tavin for pointing it out!

Thanks @tavin for pointing it out!
@rowanc1
Copy link
Member Author

rowanc1 commented May 14, 2023

The screenshots are below. The dark mode is 4px more indented (but now aligned!), but I think it is more balanced than going to a smaller margin to account for the 4px border. I really like how the light-mode has turned out, and with the changes that @tavin suggested, I think that the dark mode is a bunch nicer now as well!

Curious @tavin if you have strong thoughts on direction here, I think this is an improvement. :)

@mmcky -- also if you have thoughts on color, I didn't give it to much thought beyond copying the general scheme you put together in sphinx proof.

image

image

@tavin
Copy link
Contributor

tavin commented May 15, 2023

I like this although I find the red a bit on the "high contrast" side. But I have my own local tweaks anyway :)

@mmcky
Copy link

mmcky commented May 15, 2023

thanks @rowanc1 and @tavin -- these look like nice changes.

I will take note of this PR and try and push some of these improvements into sphinx-proof as well.

@mmcky
Copy link

mmcky commented May 15, 2023

@rowanc1

I tend to agree with this. What if the line in dark mode is the same as the background colour in light mode (for consistency?)

I like this although I find the red a bit on the "high contrast" side.

@rowanc1
Copy link
Member Author

rowanc1 commented May 15, 2023

Knocking it back a bit, much better -- good call. :)

image

image

image

@rowanc1
Copy link
Member Author

rowanc1 commented May 15, 2023

Ok -- people on twitter also like the full border.

Merging this in!

@rowanc1 rowanc1 merged commit ab65900 into main May 15, 2023
@rowanc1 rowanc1 deleted the feat/proof-alignment branch May 15, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants