Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃挰 Fix glossary terms with quotes in labels #1034

Merged
merged 1 commit into from Mar 26, 2024
Merged

馃挰 Fix glossary terms with quotes in labels #1034

merged 1 commit into from Mar 26, 2024

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Mar 26, 2024

See #833

@rowanc1 rowanc1 mentioned this pull request Mar 26, 2024
Closed
@rowanc1 rowanc1 requested a review from fwkoch March 26, 2024 18:09
fwkoch
fwkoch approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine! I don't see any big issue with making identifier normalization more normalized...

@rowanc1 rowanc1 merged commit ebe6581 into main Mar 26, 2024
4 checks passed
@rowanc1 rowanc1 deleted the feat/glossary branch March 26, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwkoch fwkoch fwkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rowanc1 @fwkoch