💬 Fix glossary terms with quotes in labels

.changeset/fluffy-geese-count.md

@@ -0,0 +1,5 @@
+---
+"myst-common": patch
+---
+
+Remove quotes from label identifiers

.changeset/hungry-ghosts-jog.md

@@ -0,0 +1,5 @@
+---
+"myst-cli": patch
+---
+
+Fix term label fixing with typography quote enhancements

packages/myst-common/src/utils.spec.ts

@@ -1,6 +1,6 @@
 import { describe, expect, test } from 'vitest';
 import { u } from 'unist-builder';
-import { liftChildren, mergeTextNodes, toText } from './utils';
+import { liftChildren, mergeTextNodes, normalizeLabel, toText } from './utils';
 
 describe('Test text utils', () => {
   test('toText', () => {
@@ -66,3 +66,18 @@ describe('Test liftChildren', () => {
     expect(before).toEqual(after);
   });
 });
+
+describe('Test normalize labels', () => {
+  test.each([
+    ['test', 'test', 'test'],
+    ['has spaces', 'has spaces', 'has-spaces'],
+    ['has    many   spaces', 'has many spaces', 'has-many-spaces'],
+    ['colon:Caps', 'colon:caps', 'colon-caps'],
+    ['“MyST’s” ‘influence’', 'mysts influence', 'mysts-influence'],
+  ])('normalize label "%s" -> "%s" (#%s)', (label, identifier, html_id) => {
+    const result = normalizeLabel(label);
+    expect(result?.label).toBe(label);
+    expect(result?.identifier).toBe(identifier);
+    expect(result?.html_id).toBe(html_id);
+  });
+});

packages/myst-common/src/utils.ts

@@ -58,6 +58,7 @@ export function normalizeLabel(
   if (!label) return undefined;
   const identifier = label
     .replace(/[\t\n\r ]+/g, ' ')
+    .replace(/['‘’"“”]+/g, '') // These can make matching difficult, especially in glossaries and terms
     .trim()
     .toLowerCase();
   const html_id = createHtmlId(identifier) as string;