What elements/styling do we want to bring over from Furo?

[pradyunsg]

As I'm completing my side-quest of writing a new Sphinx theme from scratch, now, I should be able to make a decently sized chunk of time in a few weeks to work on the bazillion issues I filed in this repository on that fateful day.

Before I do that, I figured it'd be a good idea to have a discussion about what stuff we might want to bring over from Furo's design and implementation into this theme. :)

• Collapsible ToC headings #112
• Design: Tweaking bottom-of-page content/structure #147
• Make left sidebar into an off-canvas drawer on mobile/tablet #148
• Add a shadow to the top bar on scroll #153
• Breaking up main.scss into modular bits? #219

[pradyunsg]

#219 is one that I can think of. :)

[chrisjsewell]

Just #148 and #112 are the priority changes that I was starting to think about implementing in your hiatus 😜

[choldgraf]

those are precisely the two things I was going to mention as well @chrisjsewell

I also like some of the design aspects a little bit more (nothing major, but stuff like your "previous/next" page buttons I like a bit more)

another one is the right drawer "contents" when the screen is narrow enough (forget the fact the mouse pointer doesn't hover over the contents icon, that's just my computer being weird)

[choldgraf]

ah I also like your search page more:

[chrisjsewell]

Yep Furo looking good by the way

ah I also like your search page more

for this, I've also already mentioned about a search-as-you-type UI: pydata/pydata-sphinx-theme#202

[choldgraf]

@pradyunsg out of curiosity, when do you think you'll have some cycles to work towards this? I've added this issue to the v0.1 milestone (https://github.com/executablebooks/sphinx-book-theme/milestone/1), so trying to get an idea for what kind of timetable to expect :-)

[pradyunsg]

Not 100% sure TBH -- depends on how the upcoming 20.3 release of pip goes. If it goes really well, should be able to get to these in ~15 days from now?

#219 and #112 should be easier, relatively. #148 might need reworking the HTML skeleton, soooo I'll do that last, I think?

[choldgraf]

OK - well any improvements that you can make at any time would be appreciated :-)

[pradyunsg]

FTR: #112 got a PR (and it's not me :P) -- #226.

[choldgraf]

@pradyunsg nice! Perhaps we should collect a short to-do list at the top-level comment of this issue in case others find the time and want to contribute on those as well?

[pradyunsg]

#219 is also done (via #237). That leaves us with only #147, #148 and #153 I think.

[pradyunsg]

Perhaps we should collect a short to-do list at the top-level comment of this issue in case others find the time and want to contribute on those as well?

Added! :)

[pradyunsg]

pulls head out of sand

So what was I doing again? Oh, right. #147 coming up soon-ish. :3

depends on how the upcoming 20.3 release of pip goes.

Yea, this has been interesting. Go look at https://github.com/pypa/pip/issues/ 8936 (yes, the space is intentional) if you're wondering what the heck I was upto.

[choldgraf]

+1 to your reasoning in that thread @pradyunsg 👍 this is gonna be a stressful week for a lot of the open source community for a variety of reasons

[pradyunsg]

#255 fixes #153. #257 fixes #147. 🌈

[choldgraf]

Can I assume from this that your work on getting out a new pip is complete?! If so, congratulations!!!

[pradyunsg]

Not yet, but I expect this week to be a productive one! Next week, I'll be moving countries and I'll cut the big-fish right before that. :)

[pradyunsg]

Only #148 is left. Closing since. I think we have sufficient ways to track work on that. :)

[choldgraf]

Many thanks to you @pradyunsg for following through and making these improvements, it's much appreciated and really exciting to see the energy in the Sphinx world these days :-)