Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for gitlab issue button #740

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

akhmerov
Copy link
Contributor

@akhmerov akhmerov commented Jun 3, 2023

@akhmerov
Copy link
Contributor Author

akhmerov commented Jun 3, 2023

I don't understand the CI failures, and the testing guide doesn't quite help.

EDIT: was my mistake, I figured it out.

@akhmerov
Copy link
Contributor Author

akhmerov commented Jun 3, 2023

Lighthouse failure seems unrelated, the rest of the tests are passing.

@agoose77
Copy link
Collaborator

agoose77 commented Jun 5, 2023

@akhmerov thanks for this! Would you be willing to add some tests for this? Probably looking for something similar to this test

@akhmerov
Copy link
Contributor Author

akhmerov commented Jun 5, 2023

I've updated the test, however I can't figure out how to update the reference html files. Do you have any pointers?

@akhmerov
Copy link
Contributor Author

akhmerov commented Jun 5, 2023

Should be ready now.

@akhmerov
Copy link
Contributor Author

Checking so that I don't forget about this PR; @agoose77 can you please take a look if the test is satisfactory?

@akhmerov
Copy link
Contributor Author

akhmerov commented Jul 3, 2023

@choldgraf I saw you're bumping versions in the repo. This PR should be rather straightforward and it's ready to merge 🙏 👀

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks for the ping!

@choldgraf choldgraf merged commit a9794b7 into executablebooks:master Jul 3, 2023
9 checks passed
@akhmerov akhmerov deleted the gitlab-issue-button branch July 3, 2023 12:55
@akhmerov akhmerov restored the gitlab-issue-button branch July 3, 2023 14:13
@houqp
Copy link

houqp commented Oct 4, 2023

hi, any plan to cut a new release to include this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants