Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: breaking style changes in pydata-sphinx-theme #841

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jun 12, 2024

Fixes #836 by renaming our selectors to match upstream.

@agoose77 agoose77 marked this pull request as ready for review June 12, 2024 12:26
@agoose77 agoose77 force-pushed the agoose77/fix-pydata-sphinx-theme-update branch from ce62c3c to 764f252 Compare June 12, 2024 13:15
choldgraf
choldgraf previously approved these changes Jun 12, 2024
Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks for those extra CSS changes

@agoose77
Copy link
Collaborator Author

Skipping the tests so I can merge -- I've verified only one false-positive warning.

@agoose77 agoose77 merged commit 3b6fd68 into master Jun 12, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest pydata theme release seems to have breaking impact on sphinx data theme UI
2 participants